[ 
https://issues.apache.org/jira/browse/OFBIZ-9385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643992#comment-17643992
 ] 

Jacques Le Roux edited comment on OFBIZ-9385 at 12/6/22 6:24 PM:
-----------------------------------------------------------------

Reopening because reverting 688142c5d3 in trunk resolves the issue. It seems 
that I was on a track when I spoke about ModelTree in the commit I reverted 
with 688142c5d3. I'll have a closer look tomorrow morning...


was (Author: jacques.le.roux):
Reopenins because reverting 688142c5d3 in trunk resolves the issue. It seems 
that I was on a track when I spoke about ModelTree in the commit I reverted 
with 688142c5d3. I'll have a closer look tomorrow morning...

> EntityListIterator closed but not in case of exception
> ------------------------------------------------------
>
>                 Key: OFBIZ-9385
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9385
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: 17.12.01, 22.01.01
>
>
> I found several cases. This is an improvement only because no cases were 
> reported. But obviously in case of unlucky exception after the 
> EntityListIterator creation and before it's closed the EntityListIterator 
> remains in memory. It should be closed in EntityListIterator.finalize() but 
> the less happens there the better.
> The solution is to use try-with-ressources when (easily) possible (some cases 
> are quite convoluted)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to