Daniel Watford created OFBIZ-12731:
--------------------------------------
Summary: Time zones always displayed using their daylight savings
display name
Key: OFBIZ-12731
URL: https://issues.apache.org/jira/browse/OFBIZ-12731
Project: OFBiz
Issue Type: Bug
Components: themes/helveticus, themes/rainbow
Affects Versions: 18.12.06, 22.01.01
Reporter: Daniel Watford
The timestamp displayed in the ofbiz footer will use the daylight savings
display name variant, even when the current date is outside of the daylight
savings period.
See footer of [OFBiz: Katalogverwaltung:
(apache.org).|https://demo-stable.ofbiz.apache.org/catalog/control/setSessionTimeZone?tzId=Europe/London]
At time of writing this description we are in December. Daylight savings will
not begin until March, but the timezone description is reported as British
Summer Time.
Similarly, on the ListTimezones page,
[https://demo-stable.ofbiz.apache.org/catalog/control/ListTimezones,|https://demo-stable.ofbiz.apache.org/catalog/control/ListTimezones]
we see that the 'Europe/London' timezone is also named as British Summer Time.
The incorrect display of timezone names when outside of a daylight savings
period is due to
themes/[rainbowstone|flatgrey|helveticus]/template/<includes/>Footer.ftl and
themes/common-theme/template/includes/ListTimezones.ftl.
In these FTL file, there is a call to TimeZone#getDisplayName, passing a
boolean to indicate whether the timezone name should refer to daylight savings.
A true value is passed if the timezone is currently in a daylight savings
period or will transition to daylight savings in future.
The logic should be changed to test the current time to see if daylight savings
is in effect and alter the call to TimeZone#getDisplayName accordingly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
