[ 
https://issues.apache.org/jira/browse/OFBIZ-12789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712975#comment-17712975
 ] 

ASF subversion and git services commented on OFBIZ-12789:
---------------------------------------------------------

Commit 6caa74cd7e7fc06924e0d93cfd7adfce471e3e4f in ofbiz-framework's branch 
refs/heads/trunk from Daniel Watford
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6caa74cd7e ]

Implemented: Use node/npm during gradle build from multiple sub-projects 
(OFBIZ-12789)

Added gradle plugin, ofbiz-node-conventions, to set conventional use of
the gradle node plugin across OFBiz sub-projects (i.e. components).

Modified common-theme to install and cleanup NPM modules at appropriate
points in the gradle task lifecycle.

This change will allow multiple components, including plugsin, to
leverage the gradle node plugin in their build process without needing
updates to the parent build.gradle script.


> Explore further use of npm modules to reduce bugs reported by sonarcloud
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-12789
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12789
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: themes
>    Affects Versions: Upcoming Branch
>            Reporter: Daniel Watford
>            Assignee: Daniel Watford
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>
> Sonarcloud reports 10 bugs in ofbiz sources:
> [https://sonarcloud.io/project/issues?resolved=false&types=BUG&id=apache_ofbiz-framework]
> We tend to only notice bugs in new code as they will be highlighted during 
> pull request checking.
> The majority of these bugs are related to javascript/css files under 
> themes/common-theme/webapp/common-theme not authored by the OFBiz project.
> Explore whether suitable replacements are available for these files as npm 
> modules. If so, remove those files from ofbiz-framework and replace with a 
> corresponding dependency in 
> themes/common-theme/webapp/common-theme/js/package.json.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to