[
https://issues.apache.org/jira/browse/OFBIZ-12809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714553#comment-17714553
]
ASF subversion and git services commented on OFBIZ-12809:
---------------------------------------------------------
Commit 94144bc9b658edd7daf469f2fd9d4a9ce710d1d7 in ofbiz-framework's branch
refs/heads/trunk from Daniel Watford
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=94144bc9b6 ]
Improved: Only push container images in varible set (OFBIZ-12809)
To allow the 'build and docker images' GH Actions Workflow to run in
repository forks, the build steps for logging in and pushing to the
container registry are only enabled if configuration variable
DO_DOCKER_PUSH is set to 'true'.
> Forks of ofbiz-framework attempt to push images to ghcr.io/apache/ofbiz and
> fail
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-12809
> URL: https://issues.apache.org/jira/browse/OFBIZ-12809
> Project: OFBiz
> Issue Type: Task
> Components: Docker
> Affects Versions: 22.01.01
> Reporter: Daniel Watford
> Assignee: Daniel Watford
> Priority: Minor
> Fix For: 22.01.01
>
>
> The _Build and push docker images_ github actions workflow will build docker
> container images and push them to ghcr.io/apache/ofbiz.
>
> For forks of the GH apache/ofbiz-framework repository, the push step rightly
> fails since the fork does not have permission to push to
> ghcr.io/apache/ofbiz. However the whole workflow will report a failure
> meaning the build appears to fail.
>
> Modify the workflow such that pushing of images to ghcr.io/apache/ofbiz only
> occurs for builds of the GH apache/ofbiz-framework repository.
>
> This can be implemented using environment variables where the workflow only
> attempts to log into the target container registry (i.e. ghcr.io) and push to
> that repository if a particular environment variable is set.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
