[GitHub] [ofbiz-framework] thahn27 commented on a diff in pull request #634: Improved: getConfigParam can't be configured at runtime (OFBIZ-12815)

[via GitHub]

thahn27 commented on code in PR #634:
URL: https://github.com/apache/ofbiz-framework/pull/634#discussion_r1187394823


##########
framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntityUtilProperties.java:
##########
@@ -123,6 +123,117 @@ public static String 
getPropertyValueFromDelegatorName(String resource, String n
         }
     }
 
+    public static <T> Object getPropertyValue(String resource, String name, 
Object defaultValue, Delegator delegator, Class<T> clazz) {
+        Map<String, String> propMap = getSystemPropertyValue(resource, name, 
delegator);
+        if ("Y".equals(propMap.get("isExistInDb"))) {
+            String s = propMap.get("value");
+            if (UtilValidate.isEmpty(s)) {
+                return defaultValue;
+            }
+            try {
+                if (clazz.componentType() == Integer.class) {

Review Comment:
   Hey Gil, 
   
   i closed this PR and opened another one because the commit description is 
wrong. The new PR: https://github.com/apache/ofbiz-framework/pull/635
   Also i will adjust the existing code with a switch in an upcoming commit in 
the new PR.
   
   Thanks and regards,
   Tobias



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org