[ https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748182#comment-17748182 ]
Chenghu Shan commented on OFBIZ-9403: ------------------------------------- [~mbrohl] I created a new pull request. The method getMimeType that does not use a fallback now uses content.property defaultMimeType as fallback instead. Notice that the defaultMimeType there is text/html instead of octet-stream. > DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted > (refactored) code from getMimeType(...) method > ------------------------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-9403 > URL: https://issues.apache.org/jira/browse/OFBIZ-9403 > Project: OFBiz > Issue Type: Improvement > Components: content > Affects Versions: Trunk, Upcoming Branch > Reporter: Martin Becker > Assignee: Chenghu Shan > Priority: Trivial > Attachments: OFBIZ-9403_DataResourceWorker_GetMimeType.patch, > OFBIZ-9403_DataResourceWorker_GetMimeType_with_defaultMimeTypeId.patch > > > The method DataResourceWorker.getMimeType(GenericValue) has been refactored > into two separate methods. The new additional method > getMimeTypeFromFileName(Delegator,Filename) solely focuses on getting the > MimeType from the file extension and is invoked by getMimeType(GenericValue) > if needed. getMimeType returns the type if possible via the data resource. > This results in cleaner code with the responsibility of both methods clearly > defined by the methods names. -- This message was sent by Atlassian Jira (v8.20.10#820010)