[
https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849314#comment-17849314
]
Jacques Le Roux commented on OFBIZ-13099:
-----------------------------------------
Redundant to what?
Maybe you confused with Groovy Iterator that are indeed AutoCloseable
https://docs.groovy-lang.org/latest/html/groovy-jdk/java/util/Iterator.html
But there we are using queryIterator and the documentation is clear (apart the
BEACUSE typo :))
{quote}
Open Declaration EntityListIterator
org.apache.ofbiz.entity.util.EntityQuery.queryIterator() throws
GenericEntityException
Executes the EntityQuery and returns an EntityListIterator representing the
result of the query. NOTE: THAT THIS MUST BE CLOSED (preferably in a finally
block) WHEN YOU ARE DONE WITH IT, AND DON'T LEAVE IT OPEN TOO LONG BEACUSE IT
WILL MAINTAIN A DATABASE CONNECTION.
Returns:Returns an EntityListIterator representing the result of the
queryThrows:GenericEntityException
{quote}
You don't need a finally block in Groovy but you need to use hasNext and close
as it was before your changes. TIA
> PartyFinancialHistory throws an error
> -------------------------------------
>
> Key: OFBIZ-13099
> URL: https://issues.apache.org/jira/browse/OFBIZ-13099
> Project: OFBiz
> Issue Type: Improvement
> Components: party
> Affects Versions: Upcoming Branch
> Reporter: Pierre Smits
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
>
> When accessing the financial history screen in the partymgr application (e.g.
> via
> [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier]
> following error multiple times are thrown:
> {code:java}
> 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator
> |W| For performance reasons do not use the EntityListIterator.hasNext()
> method, just call next() until it returns null; see JavaDoc comments in the
> EntityListIterator class for details and an example
> java.lang.Exception: null
> at
> org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283)
> [main/:?]
> at java_util_ListIterator$hasNext.call(Unknown Source) [?:?]
> at
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
> [groovy-3.0.21.jar:3.0.21]
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
> [groovy-3.0.21.jar:3.0.21]
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
> [groovy-3.0.21.jar:3.0.21]
> at
> org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49)
> [script:?]
> at
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213)
> [main/:?]
> at
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312)
> [main/:?]
> at
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816)
> [main/:?]
> at
> org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188)
> [main/:?]
> at
> org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:481)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:481)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:481)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:158)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:819)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:158)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:819)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:158)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:819)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:158)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:900)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:158)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:900)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:158)
> [main/:?]
> at
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:147)
> [main/:?]
> at
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:105)
> [main/:?]
> at
> org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler.render(MacroScreenViewHandler.java:116)
> [main/:?]
> at
> org.apache.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:1259)
> [main/:?]
> at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:935)
> [main/:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:231)
> [main/:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:96)
> [main/:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:529)
> [tomcat-servlet-api-9.0.86.jar:4.0.FR]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:623)
> [tomcat-servlet-api-9.0.86.jar:4.0.FR]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:209)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:153)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
> [tomcat-embed-websocket-9.0.86.jar:9.0.86]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:178)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:153)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:188)
> [main/:?]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:178)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:153)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:185)
> [main/:?]
> at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:53)
> [tomcat-servlet-api-9.0.86.jar:4.0.FR]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:178)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:153)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
> [log4j-web-2.20.0.jar:2.20.0]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:178)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:153)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:168)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:90)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:481)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:130)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:670)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:346)
> [tomcat-catalina-9.0.86.jar:9.0.86]
> at
> org.apache.coyote.http2.StreamProcessor.service(StreamProcessor.java:432)
> [tomcat-coyote-9.0.86.jar:9.0.86]
> at
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
> [tomcat-coyote-9.0.86.jar:9.0.86]
> at
> org.apache.coyote.http2.StreamProcessor.process(StreamProcessor.java:90)
> [tomcat-coyote-9.0.86.jar:9.0.86]
> at org.apache.coyote.http2.StreamRunnable.run(StreamRunnable.java:35)
> [tomcat-coyote-9.0.86.jar:9.0.86]
> at
> org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
> [tomcat-util-9.0.86.jar:9.0.86]
> at
> org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
> [tomcat-util-9.0.86.jar:9.0.86]
> at
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:63)
> [tomcat-util-9.0.86.jar:9.0.86]
> at java.lang.Thread.run(Thread.java:833) [?:?]
> 2024-05-24 10:17:35,907 |jsse-nio-8443-exec-2 |EntityListIterator
> |W| For performance reasons do not use the EntityListIterator.hasNext()
> method, just call next() until it returns null; see JavaDoc comments in the
> EntityListIterator class for details and an example
> java.lang.Exception: null {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
