The GitHub Actions job "Build and push docker images" on ofbiz-framework.git 
has failed.
Run started by GitHub user asfgit (triggered by JacquesLeRoux).

Head commit for run:
5f4f316dcbe0478f6b266a3ebf5dd0a7513943b8 / Jacques Le Roux 
<jacques.le.r...@les7arts.com>
Improved: Prevent URL parameters manipulation (OFBIZ-13147)

The "JavaScriptEnabled=Y" and "&wt=javabin" references are weaknesses.
I temporarily put them in ControlFilter::doFilter to allow things (demo and
integration tests) to work for my test (only possible on a site w. domain IP),
ie not locally.

I think we can remove  "JavaScriptEnabled=Y". I put it there because we use it
in links at https://ofbiz.apache.org/ofbiz-demos.html. Maybe other places where
it's easy to remove w/o side effects. It's anyway an user preference, not
mandatory in query string.

I needed "&wt=javabin" for the Solr tests to pass. Sometimes ago I already faced
a such issue. And then put in place what's needed. ControlFilter::isSolrTest is
the solution by generalising this usage.

Conflict handled by hand

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/11506071974

With regards,
GitHub Actions via GitBox

Reply via email to