[ 
https://issues.apache.org/jira/browse/OFBIZ-13228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17987852#comment-17987852
 ] 

Jacques Le Roux commented on OFBIZ-13228:
-----------------------------------------

Hi Nicolas,

I had already created OFBIZ-12814 that I'll close as duplicate after making it 
related (maybe info there can be useful in futur).

I want also to share some links:
Always useful: https://nightlies.apache.org/ofbiz/trunk/codenarc.html
Weird stuff: https://github.com/CodeNarc/CodeNarc/issues/447
Just for the fun: a memory from the past :) : 
https://cwiki.apache.org/confluence/display/OFBIZ/Codenarc+integration+review+tracker

> Fix all codenarc violation
> --------------------------
>
>                 Key: OFBIZ-13228
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-13228
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS, ALL PLUGINS
>            Reporter: Nicolas Malin
>            Priority: Major
>              Labels: codenarc, groovy, violation
>
> After implementation of codenarc OFBIZ-11167 we let some error due to the 
> huge work to fix them.
> We currently allow 4384 violations (410 lvl2 and 3974  lvl3) on framework and 
> plugins
> To know if we didn't introduce any new violation we need to add all plugins 
> or check the current framework violation to adapt our locale code.
> To simplify the quality development we suggest to set allow violation to 0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to