[
https://issues.apache.org/jira/browse/OFBIZ-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Vijaywargiya closed OFBIZ-4497.
--------------------------------------
Resolution: Not A Problem
The current implementation of OrderStatus is being done with good thoughts. And
various business processes in OFBiz are working fine.
In the implementation itself "StatusValidChange" entity is used properly.
The reporter can create new issues with additional details, have the discussion
with other community members, and share the patch if they can.
> OrderChangeHelper.orderStatusChanges and OrderServices.setOrderStatus has
> duplicate code
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-4497
> URL: https://issues.apache.org/jira/browse/OFBIZ-4497
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Reporter: Kiran Gawde
> Assignee: Ashish Vijaywargiya
> Priority: Minor
>
> Both OrderChangeHelper.orderStatusChanges calls
> changeOrderStatus(OrderServices.setOrderStatus) and then calls the
> changeOrderItemStatus.
> OrderServices.setOrderStatus also calls the changeOrderItemStatus (which may
> call changeOrderStatus as well).
> I think, OrderChangeHelper.orderStatusChanges should be updated so that it
> doesn't call changeOrderItemStatus.
> Also, OrderServices.setOrderStatus uses hardcoded statuses. Where as
> OrderChangeHelper.approveOrder looks them up from store. Most places, it is
> hardcoded (e.g: secas.xml).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
