Criux commented on code in PR #983:
URL: https://github.com/apache/ofbiz-framework/pull/983#discussion_r2936704139
##########
framework/base/src/main/java/org/apache/ofbiz/base/util/template/FreeMarkerWorker.java:
##########
@@ -112,10 +115,10 @@ public static Configuration
makeConfiguration(BeansWrapper wrapper) {
Configuration newConfig = newConfiguration();
newConfig.setObjectWrapper(wrapper);
- TemplateHashModel rawStaticModels = wrapper.getStaticModels();
- newConfig.setSharedVariable("Static",
RestrictedStaticModels.fromConfig(rawStaticModels, "freemarker-whitelist"));
+ TemplateHashModel staticModels = getConfiguredStaticModel(wrapper);
+ newConfig.setSharedVariable("Static", staticModels);
try {
- newConfig.setSharedVariable("EntityQuery",
rawStaticModels.get("org.apache.ofbiz.entity.util.EntityQuery"));
+ newConfig.setSharedVariable("EntityQuery",
staticModels.get("org.apache.ofbiz.entity.util.EntityQuery"));
Review Comment:
Good catch, thank you! I have reverted to the raw static models for
EntityQuery so it is always included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
