dixitdeepak commented on PR #1166: URL: https://github.com/apache/ofbiz-framework/pull/1166#issuecomment-4403345340
Thanks for the review @jacopoc Yes, the current implementation in the PR supports locking based on a single parameter only. It would definitely be useful to extend this capability to support multiple service input parameters as part of the semaphore key. I like the idea of supporting multi-attribute semaphores. However, I am still in favor of adding a new field to the ServiceSemaphore entity to store the parameter value(s). The value could be stored using a pattern similar to how EntityAuditLog.pkCombinedValueText stores combined PK values. This would keep the implementation relatively straightforward while still allowing support for composite parameter-based locking. I am moving this PR to draft for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
