pjfanning commented on code in PR #36: URL: https://github.com/apache/incubator-pekko/pull/36#discussion_r1020120540
########## CONTRIBUTING.md: ########## @@ -473,21 +462,21 @@ not needed to use `sbt scalafmtAll` when editing with IntelliJ. PR validation includes checking that the Scala sources are formatted and will fail if they are not. -Akka prefers flattened imports rather than grouped, which helps reduce merge conflicts. +Pekko prefers flattened imports rather than grouped, which helps reduce merge conflicts. If you are using IntelliJ IDEA, you can disable it by unchecking: `Preferences` -> `Code Style` -> `Scala` -> `Imports` -> `Merge imports with the same prefix into one statement`. It's recommended to run `sbt +sortImports` to keep the *import*s sorted. #### Java style -Akka uses [the sbt Java Formatter plugin](https://github.com/sbt/sbt-java-formatter) to format Java sources. +Pekko uses [the sbt Java Formatter plugin](https://github.com/sbt/sbt-java-formatter) to format Java sources. PR validation includes checking that the Java sources are formatted and will fail if they are not. #### Code discipline opt out -In addition to formatting, the Akka build enforces code discipline through a set of compiler flags. While exploring ideas, the discipline may be more of a hindrance than a help. Therefore, it is possible to disable it by setting the system property `akka.no.discipline` +In addition to formatting, the Pekko build enforces code discipline through a set of compiler flags. While exploring ideas, the discipline may be more of a hindrance than a help. Therefore, it is possible to disable it by setting the system property `akka.no.discipline` Review Comment: we have not changed any code here - so today, Pekko code uses akka sys property names - this should change after we change (or at same time) that we change the Pekko code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
