samikrc commented on code in PR #36: URL: https://github.com/apache/incubator-pekko/pull/36#discussion_r1020208614
########## CONTRIBUTING.md: ########## @@ -68,18 +62,17 @@ We encourage changes that make it easier to achieve our goals efficiently. The steps below describe how to get a patch into the main development branch (`main`). The steps are exactly the same for everyone involved in the project, including the core team and first-time contributors. -1. To avoid duplicated effort, it might be good to check the [issue tracker](https://github.com/akka/akka/issues) and [existing pull requests](https://github.com/akka/akka/pulls) for existing work. - - If there is no ticket yet, feel free to [create one](https://github.com/akka/akka/issues/new) to discuss the problem and the approach you want to take to solve it. -1. [Fork the project](https://github.com/akka/akka#fork-destination-box) on GitHub. You'll need to create a feature-branch for your work on your fork, as this way you'll be able to submit a pull request against the mainline Akka. +1. To avoid duplicated effort, it might be good to check the [issue tracker](https://github.com/apache/incubator-pekko/issues) and [existing pull requests](https://github.com/apache/incubator-pekko/pulls) for existing work. + - If there is no ticket yet, feel free to [create one](https://github.com/apache/incubator-pekko/issues/new) to discuss the problem and the approach you want to take to solve it. +1. [Fork the project](https://github.com/apache/incubator-pekko#fork-destination-box) on GitHub. You'll need to create a feature-branch for your work on your fork, as this way you'll be able to submit a pull request against the mainline Akka. 1. Create a branch on your fork and work on the feature. For example: `git checkout -b custom-headers-akka-http` - Please make sure to follow the general quality guidelines (specified below) when developing your patch. - Please write additional tests covering your feature and adjust existing ones if needed before submitting your pull request. The `validatePullRequest` sbt task ([explained below](#the-validatepullrequest-task)) may come in handy to verify your changes are correct. - Use the `verifyCodeStyle` sbt task to ensure your code is properly formatted and includes the proper copyright headers. Review Comment: Understand your comment. However, what copyright information would finally be adopted would depend on discussions with legal, which is ongoing. We can always update/finetune later. I would just retain this for now - hope this is alright. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
