Claudenw commented on PR #50: URL: https://github.com/apache/incubator-pekko/pull/50#issuecomment-1319664650
@justinmclean > 1. I don’t think this would be considered a major change. I think it is a major change as much as a sort change from bubble to quick sort would be. Original code inserted copyright and/or/ updated the date of the copyright. New code 1. Checks for presence of copyright and if found does nothing. 2. Checks for presence of Apache license and if found does nothing. 3. If the above checks fail inserts the Apache license (we could argue that this should fail the build but that is a different discussion). The new process is more complex and when it makes a change to the file the change is significantly different. Thus the change to this file rises to the level of a major change and this source should have the Apache license. Do you agree? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
