mdedetrich commented on code in PR #58: URL: https://github.com/apache/incubator-pekko/pull/58#discussion_r1027352566
########## akka-actor-testkit-typed/src/main/scala/org/apache/pekko/actor/testkit/typed/CapturedLogEvent.scala: ########## @@ -11,13 +11,14 @@ import scala.compat.java8.OptionConverters._ import org.slf4j.Marker import org.slf4j.event.Level -import akka.annotation.InternalApi -import akka.util.OptionVal +import org.apache.pekko +import pekko.annotation.InternalApi Review Comment: > I'd prefer to not import org.apache.pekko and to fully qualify the imports like pekko.annotation.InternalApi. I did it this way because it significantly reduces the diff and it also improves the quality of the produced documentation. In some places if you use the FQN it creates so much extra boilerplate that it also changes the scalafmt significantly and it also created large amounts of boilerplate in Scaladoc comments. > IDEs like IntelliJ issue warnings about pekko.annotation.InternalApi style imports even though they are valid. At least on my machine Intellij has never produced such a warning. I was actually going to provide the reasoning when the PR is done, its still ongoing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
