mdedetrich commented on code in PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#discussion_r1045083205


##########
build.sbt:
##########
@@ -102,10 +102,10 @@ lazy val root = Project(id = "pekko", base = file("."))
   .settings(PekkoBuild.welcomeSettings)
   .enablePlugins(CopyrightHeaderForBuild)
 
-lazy val actor = akkaModule("akka-actor")
+lazy val actor = pekkoModule("actor")

Review Comment:
   So the idea is to remove the `akka-`/`pekko-` prefix for sbt project names 
because its redundant (not this will not effect the `jar`/artifact, which will 
still have the `pekko-` prefix). This is however somewhat controversial so I 
was planning to make a discussion on the mailing list on it (sorry I have been 
a bit busy lately and this fell off the radar, will try to send off an email by 
end of the weekned).



##########
build.sbt:
##########
@@ -102,10 +102,10 @@ lazy val root = Project(id = "pekko", base = file("."))
   .settings(PekkoBuild.welcomeSettings)
   .enablePlugins(CopyrightHeaderForBuild)
 
-lazy val actor = akkaModule("akka-actor")
+lazy val actor = pekkoModule("actor")

Review Comment:
   So the idea is to remove the `akka-`/`pekko-` prefix for sbt project names 
because its redundant (not this will not effect the `jar`/artifact, which will 
still have the `pekko-` prefix). This is however somewhat controversial so I 
was planning to make a discussion on the mailing list on it (sorry I have been 
a bit busy lately and this fell off the radar, will try to send off an email by 
end of the weekend).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org

Reply via email to