pjfanning commented on code in PR #6:
URL:
https://github.com/apache/incubator-pekko-samples/pull/6#discussion_r1136243778
##########
akka-sample-cluster-client-grpc-java/README.md:
##########
@@ -1,7 +1,7 @@
# Cluster Client with gRPC transport
See purpose of this example and important clarifications of when to use this
approach in
-[Migration to Akka
gRPC](https://doc.akka.io/docs/akka/2.6/cluster-client.html#migration-to-akka-grpc).
+[Migration to Akka
gRPC](https://pekko.apache.org/docs/pekko/current/cluster-client.html#migration-to-akka-grpc).
Review Comment:
should be
https://pekko.apache.org/docs/pekko/current/cluster-client.html#migration-to-apache-pekko-grpc
##########
pekko-sample-distributed-data-scala/src/main/resources/application.conf:
##########
@@ -14,9 +14,9 @@ akka {
cluster {
seed-nodes = [
- "akka://[email protected]:2551",
Review Comment:
7355 is Pekko default while 2552 is Akka default
##########
akka-sample-cluster-client-grpc-scala/README.md:
##########
@@ -1,7 +1,7 @@
# Cluster Client with gRPC transport
See purpose of this example and important clarifications of when to use this
approach in
-[Migration to Akka
gRPC](https://doc.akka.io/docs/akka/2.6/cluster-client.html#migration-to-akka-grpc).
+[Migration to Akka
gRPC](https://pekko.apache.org/docs/pekko/current/cluster-client.html#migration-to-akka-grpc).
Review Comment:
should be
https://pekko.apache.org/docs/pekko/current/cluster-client.html#migration-to-apache-pekko-grpc
Would be a good idea to try the URLs to see what works
##########
pekko-sample-distributed-workers-scala/src/main/scala/worker/Main.scala:
##########
@@ -80,13 +80,13 @@ object Main {
def config(port: Int, role: String): Config =
ConfigFactory.parseString(s"""
- akka.remote.artery.canonical.port=$port
- akka.cluster.roles=[$role]
+ pekko.remote.artery.canonical.port=$port
+ pekko.cluster.roles=[$role]
""").withFallback(ConfigFactory.load())
/**
* To make the sample easier to run we kickstart a Cassandra instance to
- * act as the journal. Cassandra is a great choice of backend for Akka
Persistence but
+ * act as the journal. Cassandra is a great choice of backend for Pekko
Persistence but
Review Comment:
could you prefer `Apache Pekko` to `Pekko`? In a paragraph, where you
continuously mention Pekko, it is ok to start with `Apache Pekko` and switch to
`Pekko` but in short paragraphs, stick to `Apache Pekko`.
##########
akka-sample-cluster-client-grpc-java/README.md:
##########
@@ -1,7 +1,7 @@
# Cluster Client with gRPC transport
See purpose of this example and important clarifications of when to use this
approach in
-[Migration to Akka
gRPC](https://doc.akka.io/docs/akka/2.6/cluster-client.html#migration-to-akka-grpc).
+[Migration to Akka
gRPC](https://pekko.apache.org/docs/pekko/current/cluster-client.html#migration-to-akka-grpc).
Review Comment:
I'll let it slide but it isn't good practice to update every so many files
in a PR, could you restrict future PRs to concentrate on the dirs relating the
actual samples you are changing?
##########
pekko-sample-distributed-data-scala/src/main/resources/application.conf:
##########
@@ -14,9 +14,9 @@ akka {
cluster {
seed-nodes = [
- "akka://[email protected]:2551",
Review Comment:
could you use 7354 and 7355 as port numbers?
##########
pekko-sample-distributed-workers-scala/src/main/scala/worker/Main.scala:
##########
@@ -80,13 +80,13 @@ object Main {
def config(port: Int, role: String): Config =
ConfigFactory.parseString(s"""
- akka.remote.artery.canonical.port=$port
- akka.cluster.roles=[$role]
+ pekko.remote.artery.canonical.port=$port
+ pekko.cluster.roles=[$role]
""").withFallback(ConfigFactory.load())
/**
* To make the sample easier to run we kickstart a Cassandra instance to
- * act as the journal. Cassandra is a great choice of backend for Akka
Persistence but
+ * act as the journal. Cassandra is a great choice of backend for Pekko
Persistence but
Review Comment:
Lightbend didn't care but as a member of the ASF, I do - could you cal it
Apache Cassandra?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
