mdedetrich commented on code in PR #53:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/53#discussion_r1136774728
##########
project/Common.scala:
##########
@@ -118,6 +117,8 @@ object Common extends AutoPlugin {
// timeout.
Test / testOptions += Tests.Argument(TestFrameworks.ScalaTest, "-F", "4"),
scalafmtOnCompile := false,
- javafmtOnCompile := false,
- sonatypeProfileName := "org.apache.pekko")
+ javafmtOnCompile := false)
+
+ override lazy val buildSettings = Seq(
+ dynverSonatypeSnapshots := true)
Review Comment:
@pjfanning This is what was causing the issue. If you dont use
sbt-ci-release you need to set this value to true so that
`dynverSonatypeSnapshots` sets the project version to a snapshot unless you are
at a commit with a git tag.
The reason why it was publishing locally is that sbt-sonatype was actually
creating a local bundle which is whats used when doing a release publish and
this was happening because without `dynverSonatypeSnapshots` the projects
didn't have the `-SNAPSHOT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
