mdedetrich opened a new pull request, #66: URL: https://github.com/apache/incubator-pekko-connectors/pull/66
So this is a bug which I discovered after I added this feature (https://github.com/akka/alpakka/pull/2899) to Alpakka. Essentially, if you are using the list buckets call from a region that is not `US_EAST_1` it will fail. As noted this only occurs in AWS and not Minio (Minio is a 3rd party implementation of AWS). I have added a test to confirm this behaviour, i.e. if you revert `HttpRequests.listBuckets(s3Headers.headers), Some(Region.US_EAST_1))` to `HttpRequests.listBuckets(s3Headers.headers))` the test will fail. Unfortunately in order to replicate this you need an actual AWS account to test against (I personally used a company test account to verify this). Regarding whether this should be put into 1.1.x or 1.0.x there are arguments both ways. In the current state the `listBuckets` call will simply just fail to work if you are using a configured non `US_EAST_1` region. The only way to work around this is to manually override the attribute (i.e. https://github.com/aiven/guardian-for-apache-kafka/blob/9fce5561479d9800d82583e68b2ff1f0191d46c6/core-s3/src/test/scala/io/aiven/guardian/kafka/s3/Main.scala#L83-L92). If you do this manual workaround in conjunction with this change there is no difference, where as if you don't have this change it wont work at all. So in summary while it is a behavioural change, its very obvious and hence black and white what the change is and most critically there won't be any conflicts if users implemented a manual workaround (like the one I previously mentioned). That being said I have no issues if the community agrees to target this for 1.1.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
