mdedetrich commented on PR #251: URL: https://github.com/apache/incubator-pekko/pull/251#issuecomment-1474753171
> Cool, how about attach a test fot it too？ So I can add a test but the thing is its directly copied from [scala-collection-compat](https://github.com/scala/scala-collection-compat/pull/220) and there already is test there for this exact same function (see https://github.com/scala/scala-collection-compat/pull/220/files#diff-5465730243527013e5f690dcb15ca76177f7fc611c9024e3ab89405efb638563) so I don't think a test here is necessary. Also do note that every other function in this file is also copied from scala-colection-compat and there aren't any existing tests for those other functions either. The whole purpose of this file is to just copy the source from within scala-collection-compat in order to avoid adding a direct dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
