pjfanning commented on code in PR #14:
URL:
https://github.com/apache/incubator-pekko-samples/pull/14#discussion_r1142506341
##########
pekko-sample-cluster-client-grpc-scala/src/main/scala/sample/cluster/client/grpc/ClusterClient.scala:
##########
@@ -49,8 +49,7 @@ object ClusterClient {
private def createClientStub(
settings: ClusterClientSettings
- )(implicit mat: Materializer, sys: ActorSystem):
ClusterClientReceptionistServiceClient = {
- implicit val ec: ExecutionContext = mat.executionContext
+ )(implicit sys: ActorSystem): ClusterClientReceptionistServiceClient = {
Review Comment:
Only ActorSystem works. The background here is that the Akka sample uses
sbt-akka-grpc 0.8.4. That is an ancient version and pre 1.0.0 so the Akka team
must have changed the API before we get to sbt-akka-grpc 2.1.6 which is what
sbt-pekko-grpc is based on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
