mdedetrich opened a new pull request, #257: URL: https://github.com/apache/incubator-pekko/pull/257
While working on https://github.com/apache/incubator-pekko-connectors/pull/74 I noticed that while there is an `IterableOnce[Byte]` apply method in `ByteString` for Scala 2.13, there isn't the Scala 2.12 `Iterable[Byte]` equivalent apply method. Note that the already existing Scala 2.13 variant can be found at https://github.com/apache/incubator-pekko/blob/main/actor/src/main/scala-2.13/org/apache/pekko/util/ByteString.scala#L1002-L1009. This change can be considered safe because if you look at the implementation either for the already existing Scala 2.13 or the Scala 2.12 variant being added in this PR, in both cases it internally converts to an array. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
