mdedetrich commented on code in PR #75:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/75#discussion_r1143807369
##########
s3/src/main/scala/org/apache/pekko/stream/connectors/s3/impl/S3Stream.scala:
##########
@@ -1024,13 +1024,14 @@ import scala.util.{ Failure, Success, Try }
/**
* Initiates a multipart upload. Returns a source of the initiated upload
with upload part indicess
*/
- private def initiateUpload(s3Location: S3Location,
+ private def initiateUpload(
+ s3Location: S3Location,
contentType: ContentType,
s3Headers: immutable.Seq[HttpHeader]): Source[(MultipartUpload, Int),
NotUsed] =
Source
.single(s3Location)
.flatMapConcat(initiateMultipartUpload(_, contentType, s3Headers))
- .flatMapConcat(r => Source.repeat(r))
Review Comment:
Ah so its a performance improvement, 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
