pjfanning commented on code in PR #336: URL: https://github.com/apache/incubator-pekko/pull/336#discussion_r1203830247
########## README.md: ########## @@ -19,7 +19,8 @@ Building from Source -------------------- - You will need to install [sbt](https://www.scala-sbt.org/) if you don't already have it installed -- You should have a Java Runtime installed. Java 8 minimum. +- The Java Development Kit (JDK) used for running sbt should be Java 11 at minimum. Review Comment: Thanks - this is a good start. One nit - could you put sbt bit after the Java bit? In hindsight, sbt needs Java so we list Java first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
