mdedetrich commented on code in PR #150:
URL:
https://github.com/apache/incubator-pekko-http/pull/150#discussion_r1203958835
##########
http-core/src/main/scala/org/apache/pekko/http/impl/util/Rendering.scala:
##########
@@ -232,7 +233,7 @@ private[http] trait Rendering {
/**
* Renders the given string in double quotes.
*/
- def ~~#!(s: String): this.type = ~~('"').putEscaped(s) ~~ '"'
+ def ~~#!(s: String): this.type = this.~~('"').putEscaped(s, Rendering.`\"`,
'\\').~~('"')
Review Comment:
Another suspicious change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
