mdedetrich commented on issue #339:
URL: 
https://github.com/apache/incubator-pekko/issues/339#issuecomment-1561778507

   I would also add that if we are really forced to specify the version 
manually in source (i.e. within `build.sbt`/`version.sbt`) then we should make 
it so that the version is only set based on a flag/env variable, i.e.
   
   ```sbt
   ThisBuild / version := {
     if (releaseVersion)
        "1.0.0"
     else
        (ThisBuild / version).value
   }
   ```
   
   This means that unless you pass in `releaseVersion` it will default to the 
version provided by sbt-dynver, then at least we don't have to worry about 
constantly enabling and disabling it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to