mdedetrich commented on PR #44: URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1566084815
> https://github.com/akka/akka/commit/6b30134c5c7e8deefdfc7ff9a3e74e0bbd2d433b is the akka link and it shows that this code is part of akka 2.6.20 and since pekko 1.0.0 is meant to be a close approximation of akka 2.6.20, you could say that this is not a blocker for 1.0.0 Right but this is an exceptional circumstance, Akka basically broke the JSON framing right before the license change happened and then fixed it after the license change. I understand that we want Pekko 1.0.x to be like Akka 2.6.0 but we have done exceptions, and one of those exceptions is with critical bugs (and I would classify this as critical since it doesn't work, and it did work ~2 months(iirc) in a previous version of Akka before the license change. > I'm open to having something done about this in 1.0.0 but we sort of need a quick decision. > I would be happy with reverting https://github.com/apache/incubator-pekko/commit/6b30134c5c7e8deefdfc7ff9a3e74e0bbd2d433b Likewise, I would also suggest if this is not resolved by the time of one of the final release candidates then lets just revert the commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
