pjfanning commented on code in PR #361:
URL: https://github.com/apache/incubator-pekko/pull/361#discussion_r1209443484
##########
CONTRIBUTING.md:
##########
@@ -533,9 +533,7 @@ Scala has proven the most viable way to do it, as long as
you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java
API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Make use of `scala-java8-compat` conversions, see
[GitHub](https://github.com/scala/scala-java8-compat)
- (eg. `scala.compat.java8.FutureConverters` to translate Futures to
`CompletionStage`s).
- Note that we cannot upgrade to a newer version scala-java8-compat because
of binary compatibility issues.
+1. Use `org.apache.pekko.util.FutureConverters` to translate Futures to
`CompletionStage`s.
Review Comment:
These particular notes are for people contributing code to Pekko project.
They are not about public APIs.
Users writing code that uses Pekko: if they are using Java APIs of Pekko,
they should not be getting Scala Futures as return types - so they won't need
to convert them.
##########
CONTRIBUTING.md:
##########
@@ -533,9 +533,7 @@ Scala has proven the most viable way to do it, as long as
you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java
API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Make use of `scala-java8-compat` conversions, see
[GitHub](https://github.com/scala/scala-java8-compat)
- (eg. `scala.compat.java8.FutureConverters` to translate Futures to
`CompletionStage`s).
- Note that we cannot upgrade to a newer version scala-java8-compat because
of binary compatibility issues.
+1. Use `org.apache.pekko.util.FutureConverters` to translate Futures to
`CompletionStage`s.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
