mdedetrich commented on PR #123: URL: https://github.com/apache/incubator-pekko-connectors/pull/123#issuecomment-1568193307
> I'm not sure a Scala 3 branch is that useful. I think we should just merge the different PRs to main when they are ready. I would disagree here because unless Scala 3 works perfectly fine for all integrations we are going to dirty the branch which can cause issues later down the track if have to do modifications to Pekko connectors. iirc This is actually the same reason why the scala 3 support was in a separate branch for both akka-http and pekko-http, its because integrating Scala 3 support for the projects in question was complicated and long winding and due to the large amount of integrations I think this project passes that bar. For example the immediate problem I have is that while I think merging this is fine (from what I can tell its just doing the obligatory scala source changes just so that Scala 3 compiler can accept it) there are other more complicated changes, i.e. migrating from shapless to its new Scala 3 equivalent. If we have enough of such changes then the argument for creating a Scala 3 branch increases over time because we just end up having a lot of quite non trivial changes just to support Scala 3. In summary having a scala 3 branch allows for more iterative style development which I think is actually preferable for such a project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
