He-Pin commented on code in PR #161:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/161#discussion_r1225308688
##########
mqtt-streaming/src/test/scala/docs/scaladsl/MqttFlowSpec.scala:
##########
@@ -36,27 +36,26 @@ import org.scalatest.matchers.should.Matchers
import org.scalatest.wordspec.AnyWordSpecLike
class UntypedMqttFlowSpec
- extends ParametrizedTestKit("untyped-flow-spec/flow",
+ extends MqttFlowSpecBase("untyped-flow-spec/flow",
"untyped-flow-spec/topic1",
ActorSystem("UntypedMqttFlowSpec"))
- with MqttFlowSpec
+
class TypedMqttFlowSpec
- extends ParametrizedTestKit("typed-flow-spec/flow",
+ extends MqttFlowSpecBase("typed-flow-spec/flow",
"typed-flow-spec/topic1",
- org.apache.pekko.actor.typed.ActorSystem(Behaviors.ignore,
"TypedMqttFlowSpec").toClassic)
- with MqttFlowSpec
-
-class ParametrizedTestKit(val clientId: String, val topic: String, system:
ActorSystem) extends TestKit(system)
+ pekko.actor.typed.ActorSystem(Behaviors.ignore,
"TypedMqttFlowSpec").toClassic)
-trait MqttFlowSpec extends AnyWordSpecLike with Matchers with
BeforeAndAfterAll with ScalaFutures with LogCapturing {
- self: ParametrizedTestKit =>
+abstract class MqttFlowSpecBase(val clientId: String, val topic: String,
system: ActorSystem) extends TestKit(system)
Review Comment:
`val` can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
