pjfanning commented on code in PR #159:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/159#discussion_r1225349344
##########
google-cloud-storage/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/storage/impl/Formats.scala:
##########
@@ -110,8 +110,8 @@ object Formats extends DefaultJsonProtocol {
StorageObjectJson(readOnlyFields, writeableFields)
}
override def write(obj: StorageObjectJson): JsValue = {
- val fields1 = obj.readable.toJson.asJsObject.fields
- val fields2 = obj.writeable.toJson.asJsObject.fields
+ val fields1 = spray.json.enrichAny(obj.readable).toJson.asJsObject.fields
+ val fields2 =
spray.json.enrichAny(obj.writeable).toJson.asJsObject.fields
Review Comment:
won't compile - it says that `.toJson` is not a method on the relevent
classes. The implicit conversion `enrichAny` is not happening - so I have to do
it explicitly.
Scala 3 compiler, unfortunately, still has some bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
