mdedetrich commented on code in PR #165:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/165#discussion_r1225764876
##########
google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/javadsl/GooglePubSub.scala:
##########
@@ -61,15 +62,20 @@ object GooglePubSub {
.setStreamAckDeadlineSeconds(0)
.build()
- subscriber(mat, attr).client
+ val streamingPullResult: Source[StreamingPullResponse, NotUsed] =
subscriber(mat, attr).client
.streamingPull(
Source
.single(request)
.concat(
Source
.tick(Duration.ZERO, pollInterval, subsequentRequest)
.mapMaterializedValue(cancellable.complete(_))))
- .mapConcat(_.getReceivedMessagesList)
+
+ streamingPullResult
+ .mapConcat(new function.Function[StreamingPullResponse,
java.util.List[ReceivedMessage]] {
Review Comment:
@pjfanning This version works for all versions of Scala (including Scala 3)
```scala
.mapConcat(
((response: StreamingPullResponse) =>
response.getReceivedMessagesList):
pekko.japi.function.Function[StreamingPullResponse,
java.lang.Iterable[ReceivedMessage]])
```
Issue appears to be due to the fact that these are custom function
interfaces that Pekko has defined, I will report this upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
