pjfanning commented on code in PR #170:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/170#discussion_r1225780364
##########
ftp/src/main/scala/org/apache/pekko/stream/connectors/ftp/javadsl/FtpApi.scala:
##########
@@ -573,6 +573,6 @@ object Sftp extends SftpApi {
*/
def create(customSshClient: SSHClient): SftpApi =
new SftpApi {
- override val sshClient: SSHClient = customSshClient
Review Comment:
* more scala3 compiler issues
* the super class has `def sshClient(): SSHClient`
* the `()` seem to be the reason that the override can't make it a `val`
* `customSshClient` is a constant as far as the anonymous class `new SftpApi
{` is concerned
* so there will be no recalculation on each call to `def sshClient():
SSHClient`
* one option would be to make it `final def sshClient(): SSHClient` --
but with anonymous classes, you would assume everything is implied to be final
anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
