pjfanning commented on code in PR #158:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/158#discussion_r1226403888
##########
avroparquet/src/test/scala/docs/scaladsl/AbstractAvroParquetBase.scala:
##########
@@ -42,13 +34,13 @@ trait AbstractAvroParquet extends BeforeAndAfterAll {
Gen.oneOf(Seq(Document(id = Gen.alphaStr.sample.get, body =
Gen.alphaLowerStr.sample.get)))
val genDocuments: Int => Gen[List[Document]] = n => Gen.listOfN(n,
genDocument)
- val format: RecordFormat[Document] = RecordFormat[Document]
-
val folder: String = "./" + Random.alphanumeric.take(8).mkString("")
val genFinalFile: Gen[String] = for {
fileName <- Gen.alphaLowerStr
- } yield { folder + "/" + fileName + ".parquet" }
+ } yield {
+ folder + "/" + fileName + ".parquet"
Review Comment:
this code was just moved around - I did not rewrite it - I just need to have
the code set up so some code can be different in Scala 2 and Scala 3
it would be bad imo for me to start rewriting working code in a PR that is
about purely Scala3 support
if we want to rewrite working code that we don't like, we really need new PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
