mdedetrich commented on PR #385: URL: https://github.com/apache/incubator-pekko/pull/385#issuecomment-1588790701
> > So I have made one comment regarding the sequential id generator which is only used in tests. > > Regarding the various configurable id algorithms being added, is the intention here to merge this PR and then add a thread safe version of @Claudenw 's algorithm after the PR. @pjfanning @He-Pin ? > > I don't really see the new for adding the extra pseudorandom id generator. Maybe we could add it later. > > My aim is to press forward to a release and we don't really need multiple generators to be supported. Well we can always add it after this PR, its a shame to have the effort spent wasted. But agreed that it shouldn't block the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
