pjfanning commented on code in PR #91:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/91#discussion_r1228017899
##########
plugin-tester-scala/src/test/scala/example/myapp/helloworld/ErrorReportingSpec.scala:
##########
@@ -37,7 +37,7 @@ import scala.concurrent.duration._
@RunWith(classOf[JUnitRunner])
class ErrorReportingSpec extends AnyWordSpec with Matchers with ScalaFutures
with BeforeAndAfterAll {
- override implicit val patienceConfig = PatienceConfig(5.seconds, Span(100,
org.scalatest.time.Millis))
+ override implicit val patienceConfig: PatienceConfig =
PatienceConfig(5.seconds, Span(100, org.scalatest.time.Millis))
Review Comment:
this is test code and there are dozens of entries like this in the tests -
none are final - if we don't like existing code patterns, they can be changed -
but in their own PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
