pjfanning commented on PR #385: URL: https://github.com/apache/incubator-pekko/pull/385#issuecomment-1589269201
> @IainHull @pjfanning @pjfanning Are there any objections to adding @Claudenw random solution described at [#385 (comment)](https://github.com/apache/incubator-pekko/pull/385#discussion_r1228053082) ? Making it thread safe would largely be trivial (i.e. adding `synchronized` to `nextId()`) and the final result shouldn't be too slow, at least compared to making `SecureRandom`/`SHA256` thread safe. > > I can rebase/target my PR #371 against this PR to bring in @IainHull 's changes and add another algorithm option, or we can just merge this PR as is and then I will rebase mine. Couldn't we merge this and add a new generator and make it the default generator if that makes sense? We won't release until all the conversations are complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
