pjfanning commented on PR #93: URL: https://github.com/apache/incubator-pekko-grpc/pull/93#issuecomment-1591062996
> @pjfanning So I had a look at the error and its actually due to newer linting options that was added to Scala, i.e. one of the errors > > ``` > [error] /home/runner/work/incubator-pekko-grpc/incubator-pekko-grpc/runtime/src/test/scala/org/apache/pekko/grpc/internal/PekkoDiscoveryNameResolverProviderSpec.scala:49:25: Implicit definition should have explicit type (inferred PekkoDiscoveryNameResolverProviderSpec.this.PatienceConfig) > [error] implicit override val patienceConfig = > [error] ^ > [error] one error found > ``` > > Should easily be solved by just adding an explicit type signature which is nothing new. These linting options were added for reason because they mirror whats in Scala 3, ill try to fix this in a new PR. I found that myself just now and have https://github.com/apache/incubator-pekko-grpc/pull/93 (found using https://github.com/apache/incubator-pekko-grpc/pull/92) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
