mdedetrich commented on code in PR #392:
URL: https://github.com/apache/incubator-pekko/pull/392#discussion_r1229965916
##########
project/Paradox.scala:
##########
@@ -37,14 +38,20 @@ object Paradox {
"extref.github.base_url" -> (GitHub.url(version.value) + "/%s"), // for
links to our sources
"extref.samples.base_url" ->
s"$pekkoBaseURL/docs/pekko-samples/current/%s",
"pekko.doc.dns" -> s"$pekkoBaseURL",
- "scaladoc.pekko.base_url" ->
s"$pekkoBaseURL/api/pekko/current/org/apache",
+ "scaladoc.pekko.base_url" ->
s"$pekkoBaseURL/api/pekko/${projectInfoVersion.value}/org/apache",
"scaladoc.pekko.http.base_url" ->
s"$pekkoBaseURL/api/pekko-http/current/org/apache",
+ "scaladoc.org.apache.pekko.base_url" ->
s"$pekkoBaseURL/api/pekko/${projectInfoVersion.value}",
Review Comment:
This is necessary because `scaladoc.pekko.base_url` only works with the
`@apidoc` directive because its only `@apidoc` directive that has a concept of
root package, i.e.
https://github.com/apache/incubator-pekko/blob/a0c6bffe5d6bc5f012f7258bc7d9c95c77cf6379/project/Paradox.scala#L120
This means that another entry needs to be added for
`scaladoc.org.apache.pekko.base_url`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
