mdedetrich commented on PR #388: URL: https://github.com/apache/incubator-pekko/pull/388#issuecomment-1591963342
So I just updated the PR to remove the `final` from `remote/src/main/scala/org/apache/pekko/remote/artery/Association.scala`. Note that `Association` is marked as private and internal ABI so we can also add it later but the `@inline` that is already there is like a mistake (its not possible to inline because `compareAndSwapObject` is from java SDK). Its like that methods calling `swapState` need to be inlined but again that is something we can do later since this is all private internal pekko stuff/ The `ByteString` methods here are more critical Will merge PR once tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
