pjfanning commented on code in PR #371:
URL: https://github.com/apache/incubator-pekko/pull/371#discussion_r1230261109
##########
actor/src/main/resources/reference.conf:
##########
@@ -1145,11 +1145,13 @@ pekko {
# other platforms, will default to 1).
ndots = default
- # The policy used to generate dns transaction ids. Options are
thread-local-random or secure-random.
- # Defaults to thread-local-random similar to Netty, secure-random
produces FIPS compliant random numbers but
- # could block looking for entropy (these are short integers so are
easy to bruit-force, use thread-local-random
- # unless you really require FIPS compliant random numbers).
- id-generator-policy = thread-local-random
+ # The policy used to generate dns transaction ids. Options are
thread-local-random, enhanced-double-hash-random
Review Comment:
Could you put the values in quotes? This makes them stand out a bit more.
'bruit' should 'brute' as in brute force.
Could you change 'initial seed, thread-local-random' to this (with a full
stop instead of a comma)?
```
initial seed. 'thread-local-random'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
