pjfanning commented on code in PR #452:
URL: https://github.com/apache/incubator-pekko/pull/452#discussion_r1239666111
##########
docs/src/main/paradox/typed/fault-tolerance.md:
##########
@@ -117,7 +117,7 @@ It is possible to override this so that child actors are
not influenced when the
The restarted parent instance will then have the same children as before the
failure.
If child actors are created from @apidoc[setup](typed.*.Behaviors$)
{scala="#setup[T](factory:org.apache.pekko.actor.typed.scaladsl.ActorContext[T]=%3Eorg.apache.pekko.actor.typed.Behavior[T]):org.apache.pekko.actor.typed.Behavior[T]"
java="#setup(org.apache.pekko.japi.function.Function)"} like in the previous
example and they should remain intact (not stopped)
-when parent is restarted the @apidoc[supervise](typed.*.Behaviors$)
{scala="#supervise[T](wrapped:org.apache.pekko.actor.typed.Behavior[T]):org.apache.pekko.actor.typed.scaladsl.Behaviors.Supervise[T]"
java="#supervise(org.apache.pekko.actor.typed.Behavior)"} should be placed
inside the @apidoc[setup](typed.*.Behaviors$)
{scala="#setup[T](factory:org.apache.pekko.actor.typed.scaladsl.ActorContext[T]=%3Eorg.apache.pekko.actor.typed.Behavior[T]):org.apache.pekko.actor.typed.Behavior[T]"
java="#setup(org.apache.pekko.japi.function.Function)"} and using
+when parent is restarted, the @apidoc[supervise](typed.*.Behaviors$)
{scala="#supervise[T](wrapped:org.apache.pekko.actor.typed.Behavior[T]):org.apache.pekko.actor.typed.scaladsl.Behaviors.Supervise[T]"
java="#supervise(org.apache.pekko.actor.typed.Behavior)"} should be placed
inside the @apidoc[setup](typed.*.Behaviors$)
{scala="#setup[T](factory:org.apache.pekko.actor.typed.scaladsl.ActorContext[T]=%3Eorg.apache.pekko.actor.typed.Behavior[T]):org.apache.pekko.actor.typed.Behavior[T]"
java="#setup(org.apache.pekko.japi.function.Function)"} and using
Review Comment:
@nvollmar do you mean that `@apidoc[supervise]` should be
`@apidoc[supervisee]` ? If so, I can add that to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
