mdedetrich commented on code in PR #167:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/167#discussion_r1249747354
##########
s3/src/main/scala/org/apache/pekko/stream/connectors/s3/impl/S3Stream.scala:
##########
@@ -1177,11 +1177,15 @@ import scala.util.{ Failure, Success, Try }
import conf.multipartUploadSettings.retrySettings._
- SplitAfterSize(chunkSize, chunkBufferSize)(atLeastOneByteString)
- .via(getChunkBuffer(chunkSize, chunkBufferSize, maxRetries)) //
creates the chunks
- .mergeSubstreamsWithParallelism(parallelism)
+ val source1: SubFlow[Chunk, NotUsed, Flow[ByteString, ByteString,
NotUsed]#Repr, Sink[ByteString, NotUsed]] =
Review Comment:
I presume that this type annotation was auto generated from Intellij and if
so it likely can be simplified a bit more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
