mdedetrich opened a new pull request, #100: URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/100
Resolves: https://github.com/apache/incubator-pekko-connectors-kafka/issues/85 This PR reuses the upstream Kafka mechanism that is used to filter/mask passwords. In more detail, Kafka has its own `org.apache.kafka.common.config.AbstractConfig` which actually maintains types for keys. One of those types is `kafka.common.config.ConfigDef.Type.PASSWORD` which is how upstream Kafka determines whether any sensitive field needs to be masked (see https://github.com/apache/kafka/blob/51bc41031b91b16ffcbd95832e8a20a00d3b6f81/clients/src/main/java/org/apache/kafka/common/config/types/Password.java#L54-L57 for more info). Also note that this project already has tests for determining if the filtering is working (see https://github.com/mdedetrich/incubator-pekko-connectors-kafka/blob/0a55b158d2d7fd8c050ab147d80d259a79e3ffe2/tests/src/test/scala/org/apache/pekko/kafka/ConsumerSettingsSpec.scala#L107-L117 and https://github.com/mdedetrich/incubator-pekko-connectors-kafka/blob/0a55b158d2d7fd8c050ab147d80d259a79e3ffe2/tests/src/test/scala/org/apache/pekko/kafka/ProducerSettingsSpec.scala#L91-L101) so I can confirm that it works (i.e. there is no regression). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
