mdedetrich commented on code in PR #101:
URL:
https://github.com/apache/incubator-pekko-connectors-kafka/pull/101#discussion_r1259348758
##########
core/src/main/scala/org/apache/pekko/kafka/javadsl/MetadataClient.scala:
##########
@@ -99,7 +99,7 @@ class MetadataClient private (metadataClient:
pekko.kafka.scaladsl.MetadataClien
object MetadataClient {
def create(consumerActor: ActorRef, timeout: Timeout, executor: Executor):
MetadataClient = {
- implicit val ec: ExecutionContextExecutor =
ExecutionContexts.fromExecutor(executor)
+ implicit val ec: ExecutionContext =
ExecutionContexts.fromExecutor(executor)
Review Comment:
This change is to make it consistent with the rest of the codebase (we
always type ec's to `ExecutionContext`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
