mdedetrich commented on PR #205: URL: https://github.com/apache/incubator-pekko-connectors/pull/205#issuecomment-1657772130
I would have preferred if the tests were written in Scala using the already established Mockito in `Dependencies.scala` (see https://github.com/apache/incubator-pekko-connectors/blob/79ec6fa65305dd933ef67063b88419bc98424f69/project/Dependencies.scala#L76-L79) rather than just adding a new Mockito dependency and writing the test in Java. https://github.com/apache/incubator-pekko-connectors/blob/c207c292ee9fecec2444637c84d63b9127280422/amqp/src/test/scala/org/apache/pekko/stream/connectors/amqp/scaladsl/AmqpFlowSpec.scala is an example of a test that was written with scalatest/mockito. @TheDeadOne Would this be something that you are able to do? Otherwise I can redo the test on your PR. . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
