mdedetrich commented on code in PR #122:
URL:
https://github.com/apache/incubator-pekko-connectors-kafka/pull/122#discussion_r1280978593
##########
CONTRIBUTING.md:
##########
@@ -96,6 +96,12 @@ Example:
* Details 2
* Details 3
+## Applying code style to the project
+
+The project uses [scalafmt](https://scalameta.org/scalafmt/) to ensure code
quality which is automatically checked on
+every PR. If you would like to check for any potential code style problems
locally you can run `sbt checkCodeStyle`
+and if you want to apply the code style then you can run `sbt applyCodeStyle`.
Review Comment:
> Should we suggest `+checkCodeStyle` and `+applyCodeStyle`? Ensures that
code that is Scala version specific gets checked and/or updated too.
Both the scalafmt and sbt-java-formatter formatters don't do typechecking
which means they don't involve scalac/javac (both formatters just parse
scala/java source code and format based on that).
In other words, they will produce the exact same result regardless of the
scala version, so the `+` is not required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
