mdedetrich commented on code in PR #530:
URL: https://github.com/apache/incubator-pekko/pull/530#discussion_r1282999008
##########
.github/workflows/binary-compatibility-checks.yml:
##########
@@ -43,11 +38,11 @@ jobs:
run: cp .jvmopts-ci .jvmopts
- name: Compile code
- run: sbt "+~ ${{ matrix.scalaVersion }} Test/compile"
Review Comment:
There is no reason to also compile `Test` scope, the point of this github
check is to validate binary compatibility issues and this is never done against
test code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
