pjfanning commented on code in PR #539:
URL: https://github.com/apache/incubator-pekko/pull/539#discussion_r1285036594
##########
project/SbtMultiJvm.scala:
##########
@@ -372,7 +373,13 @@ object MultiJvmPlugin extends AutoPlugin {
val connectInput = input && index == 0
log.debug("Starting %s for %s".format(jvmName, testClass))
log.debug(" with JVM options: %s".format(allJvmOptions.mkString(" ")))
- (testClass, Jvm.startJvm(javaBin, allJvmOptions, runOptions,
jvmLogger, connectInput))
+ val testClass2Process = (testClass, Jvm.startJvm(javaBin,
allJvmOptions, runOptions, jvmLogger, connectInput))
+ if (index == 0) {
+ log.debug("%s for %s 's started as `Controller`, waiting 2 seconds
before start clients.".format(jvmName,
+ testClass))
+ TimeUnit.SECONDS.sleep(2)
Review Comment:
I don't like time based waits. On a slow machine, they can stop working. Our
CI builds on VMs that can be very slow.
Is there any way that this code could be changed to ping the netty cluster
and keep doing so until it gets notification that the cluster is ready?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
